From: Jiri Slaby Date: Thu, 4 Apr 2013 19:32:09 +0000 (-0300) Subject: [media] MEDIA: ttusbir, fix double free X-Git-Tag: archive/raspbian/4.9.13-1+rpi1~10^2~6276^2~2107 X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:///%22http:/www.example.com/cgi/%22https:/www.github.com/%22bookmarks:/?a=commitdiff_plain;h=a9bd87c232b87014b20fdf52416f80c5c1e869fc;p=linux-4.9.git [media] MEDIA: ttusbir, fix double free rc_unregister_device already calls rc_free_device to free the passed device. But in one of ttusbir's probe fail paths, we call rc_unregister_device _and_ rc_free_device. This is wrong and results in a double free. Instead, set rc to NULL resulting in rc_free_device being a noop. Signed-off-by: Jiri Slaby Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c index cf0d47f57fb2..891762d167ed 100644 --- a/drivers/media/rc/ttusbir.c +++ b/drivers/media/rc/ttusbir.c @@ -347,6 +347,7 @@ static int ttusbir_probe(struct usb_interface *intf, return 0; out3: rc_unregister_device(rc); + rc = NULL; out2: led_classdev_unregister(&tt->led); out: